Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ts strict in query package #2447

Merged
merged 7 commits into from
Jun 18, 2024
Merged

enable ts strict in query package #2447

merged 7 commits into from
Jun 18, 2024

Conversation

yoozo
Copy link
Collaborator

@yoozo yoozo commented Jun 13, 2024 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

enable ts strict mode in query package

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

dependabot bot and others added 3 commits June 13, 2024 09:44
@dependabot
Bump @grpc/grpc-js from 1.9.7 to 1.10.9 (#2436)
e5e8541 
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.9.7 to 1.10.9.
- [Release notes](https://github.com/grpc/grpc-node/releases)
- [Commits](https://github.com/grpc/grpc-node/compare/@grpc/[email protected]...@grpc/[email protected])

---
updated-dependencies:
- dependency-name: "@grpc/grpc-js"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@yoozo
query enable ts strict
60075ea
@yoozo
some change
afa8b35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

Coverage report for .

Caution

Test run failed

St.❔
 Category Percentage Covered / Total
🟡 Statements
65.07% (-5.04% 🔻)
 18686/28717
🟡 Branches
79.2% (+0.91% 🔼)
 2403/3034
🟡 Functions
66.13% (+3.63% 🔼)
 1035/1565
🟡 Lines
65.07% (-5.04% 🔻)
 18686/28717
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / migrate.ts
 85.09% 18.18% 100% 85.09%
🟢
... / migrate-abis.controller.ts
 95% 87.5% 100% 95%
🟢
... / constants.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / ethereum.ts
 82.05% 83.33% 100% 82.05%
🟢
... / migrate-manifest.controller.ts
 88% 73.33% 88.89% 88%
🟢
... / migrate-mapping.controller.ts
 100% 100% 100% 100%
🟢
... / migrate-controller.ts
 92.31% 84.62% 100% 92.31%
🟢
... / migrate.fixtures.ts
 100% 100% 100% 100%
🟢
... / migrate-schema.controller.ts
 100% 100% 100% 100%
🔴
... / types.ts
 0% 0% 0% 0%
🟢
... / createProject.fixtures.ts
 96.88% 80% 100% 96.88%
🟢
... / networkFamily.ts
 92.59% 88.89% 100% 92.59%
🟡
... / admin.controller.ts
 77.24% 96.3% 78.57% 77.24%
🔴
... / blockRange.ts
 46.67% 100% 50% 46.67%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / dictionary.fixtures.ts
 100% 100% 100% 100%
🟡
... / monitor.service.ts
 65.73% 84.62% 94.12% 65.73%
🔴
... / sandbox.service.ts
 33.33% 50% 25% 33.33%
🔴
... / worker.monitor.service.ts
 41.46% 100% 0% 41.46%
🔴
... / process.ts
 50% 66.67% 40% 50%
🔴
... / foreceClean.init.ts
 47.62% 100% 0% 47.62%
🔴
... / reindex.init.ts
 34.48% 100% 0% 34.48%
🟢
... / string.ts
 100% 100% 100% 100%
🔴
... / admin.module.ts
 0% 0% 0% 0%
🔴
... / datasourceProcessors.ts
 0% 0% 0% 0%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / deploy.ts
18.91% (-2.24% 🔻)
 100%
50% (+50% 🔼)
18.91% (-2.24% 🔻)
🔴
... / publish.ts
44% (-45.33% 🔻)
40% (-17.14% 🔻)
 100%
44% (-45.33% 🔻)
🔴
... / deploy-controller.ts
32.49% (-4.98% 🔻)
100% (+22.22% 🔼)
12.5% (-12.5% 🔻)
32.49% (-4.98% 🔻)
🟢
... / generate-controller.ts
 97.65%
93.85% (-0.18% 🔻)
 100% 97.65%
🟡
... / init-controller.ts
72.89% (+2.4% 🔼)
54.55% (-13.45% 🔻)
61.11% (+7.78% 🔼)
72.89% (+2.4% 🔼)
🔴
... / project-controller.ts
17.81% (-79.45% 🔻)
100% (+40% 🔼)
0% (-100% 🔻)
17.81% (-79.45% 🔻)
🔴
... / publish-controller.ts
59.34% (-20.91% 🔻)
58.62% (-12.49% 🔻)
60% (-40% 🔻)
59.34% (-20.91% 🔻)
🔴
... / models.ts
53.33% (-46.11% 🔻)
94.44% (+2.14% 🔼)
38.46% (-61.54% 🔻)
53.33% (-46.11% 🔻)
🟢
... / ProjectManifestVersioned.ts
82.19% (-2.74% 🔻)
88.89% (-11.11% 🔻)
61.54% (+3.21% 🔼)
82.19% (-2.74% 🔻)
🟢
... / model.ts
93.14% (-4.57% 🔻)
 100%
73.33% (+1.9% 🔼)
93.14% (-4.57% 🔻)
🔴
... / models.ts
47.06% (-52.94% 🔻)
 100%
0% (-100% 🔻)
47.06% (-52.94% 🔻)
🔴
... / load.ts
 59.18%
50% (-5.56% 🔻)
 66.67% 59.18%
🔴
... / utils.ts
50.95% (-11.75% 🔻)
88% (+14.83% 🔼)
52% (-4% 🔻)
50.95% (-11.75% 🔻)
🔴
... / base.ts
40.4% (-57.6% 🔻)
87.5% (-12.5% 🔻)
40% (-40% 🔻)
40.4% (-57.6% 🔻)
🔴
... / models.ts
25.32% (-74.68% 🔻)
 100%
0% (-100% 🔻)
25.32% (-74.68% 🔻)
🟢
... / NodeConfig.ts
88.48% (-0.12% 🔻)
77.59% (-2.04% 🔻)
86.96% (+0.91% 🔼)
88.48% (-0.12% 🔻)
🟡
... / ProjectUpgrade.service.ts
71.74% (-15.34% 🔻)
87.14% (-4.22% 🔻)
84% (-7.3% 🔻)
71.74% (-15.34% 🔻)
🟢
... / db.module.ts
89.06% (+0.78% 🔼)
62.5% (-20.83% 🔻)
 80%
89.06% (+0.78% 🔼)
🟡
... / migration-helpers.ts
75.28% (-0.74% 🔻)
88.24% (+7.64% 🔼)
 90.91%
75.28% (-0.74% 🔻)
🟢
... / sync-helper.ts
85.42% (-2.96% 🔻)
 88.04%
73.77% (-1.23% 🔻)
85.42% (-2.96% 🔻)
🟡
... / StoreOperations.ts
72.94% (-19.37% 🔻)
86.36% (+1.36% 🔼)
87.5% (-12.5% 🔻)
72.94% (-19.37% 🔻)
🔴
... / benchmark.service.ts
43.36% (-11.89% 🔻)
 66.67%
36.36% (-3.64% 🔻)
43.36% (-11.89% 🔻)
🔴
... / base-block-dispatcher.ts
19% (-28.35% 🔻)
 100%
4.35% (-5.65% 🔻)
19% (-28.35% 🔻)
🔴
... / block-dispatcher.ts
26.98% (-14.01% 🔻)
 66.67%
25% (-3.57% 🔻)
26.98% (-14.01% 🔻)
🔴
... / worker-block-dispatcher.ts
36.17% (-14.04% 🔻)
 100%
25% (-2.27% 🔻)
36.17% (-14.04% 🔻)
🔴
... / coreDictionary.ts
42.67% (-57.33% 🔻)
86.67% (-7.78% 🔻)
66.67% (-33.33% 🔻)
42.67% (-57.33% 🔻)
🟡
... / dictionary.service.ts
67% (-18.15% 🔻)
80% (-5.71% 🔻)
83.33% (-7.58% 🔻)
67% (-18.15% 🔻)
🟡
... / dictionaryV1.ts
72.24% (-20.98% 🔻)
71.11% (-7.15% 🔻)
83.33% (-16.67% 🔻)
72.24% (-20.98% 🔻)
🟡
... / dictionaryV2.ts
67.37% (-14.31% 🔻)
68% (+2.78% 🔼)
88.89% (-11.11% 🔻)
67.37% (-14.31% 🔻)
🔴
... / ds-processor.service.ts
39.37% (-22.72% 🔻)
 75%
58.33% (-29.17% 🔻)
39.37% (-22.72% 🔻)
🔴
... / dynamic-ds.service.ts
59.84% (-30.35% 🔻)
65% (-1.67% 🔻)
80% (-5.71% 🔻)
59.84% (-30.35% 🔻)
🟢
... / inMemoryCache.service.ts
86.21% (-13.79% 🔻)
 100%
75% (-25% 🔻)
86.21% (-13.79% 🔻)
🔴
... / indexer.manager.ts
16.13% (-17.08% 🔻)
 100%
10% (-2.5% 🔻)
16.13% (-17.08% 🔻)
🟢
... / PoiBlock.ts
83.87% (-14.52% 🔻)
 96.55%
75% (-25% 🔻)
83.87% (-14.52% 🔻)
🔴
... / poi.service.ts
56.64% (+32.71% 🔼)
55.56% (-44.44% 🔻)
80% (+51.43% 🔼)
56.64% (+32.71% 🔼)
🔴
... / poiModel.ts
40% (-23.64% 🔻)
 71.43%
44.44% (-12.7% 🔻)
40% (-23.64% 🔻)
🔴
... / poiSync.service.ts
55.88% (-31% 🔻)
77.61% (+1.05% 🔼)
88.89% (-3.42% 🔻)
55.88% (-31% 🔻)
🟡
... / project.service.ts
66.45% (-13.55% 🔻)
71.43% (+1.25% 🔼)
80.77% (-3.23% 🔻)
66.45% (-13.55% 🔻)
🟡
... / sandbox.ts
60.49% (-7.49% 🔻)
 57.14%
57.14% (-4.4% 🔻)
60.49% (-7.49% 🔻)
🔴
... / smartBatch.service.ts
10.43% (-13.91% 🔻)
 100%
12.5% (-1.79% 🔻)
10.43% (-13.91% 🔻)
🟡
... / store.service.ts
64.45% (-1.59% 🔻)
69.23% (+0.81% 🔼)
54.84% (-2.3% 🔻)
64.45% (-1.59% 🔻)
🔴
... / entity.ts
19.23% (-42.31% 🔻)
 100% 0%
19.23% (-42.31% 🔻)
🔴
... / store.ts
13.11% (-19.09% 🔻)
 100% 0%
13.11% (-19.09% 🔻)
🟢
... / cacheMetadata.ts
 88.51%
74.42% (-1.14% 🔻)
93.75% (+0.42% 🔼)
 88.51%
🟡
... / cacheModel.ts
68.89% (-16.18% 🔻)
85.92% (+7.6% 🔼)
71.43% (-4.76% 🔻)
68.89% (-16.18% 🔻)
🟡
... / cachePoi.ts
75.53% (-18.09% 🔻)
 88.89%
71.43% (-11.9% 🔻)
75.53% (-18.09% 🔻)
🟢
... / cacheable.ts
89.66% (-0.97% 🔻)
 75% 100%
89.66% (-0.97% 🔻)
🟡
... / csvStore.service.ts
76.92% (-14.1% 🔻)
 80%
80% (-20% 🔻)
76.92% (-14.1% 🔻)
🟢
... / test.runner.ts
94.67% (-4.67% 🔻)
 73.33%
66.67% (-33.33% 🔻)
94.67% (-4.67% 🔻)
🔴
... / testing.service.ts
12% (-16.57% 🔻)
 100% 0%
12% (-16.57% 🔻)
🟡
... / unfinalizedBlocks.service.ts
63.19% (-20.79% 🔻)
 96.72%
88% (-3.67% 🔻)
63.19% (-20.79% 🔻)
🔴
... / worker.builder.ts
59.83% (-19.36% 🔻)
 65.38% 80%
59.83% (-19.36% 🔻)
🔴
... / worker.cache.service.ts
48.78% (-9.76% 🔻)
 100% 0%
48.78% (-9.76% 🔻)
🔴
... / worker.connectionPoolState.manager.ts
38.21% (-22.76% 🔻)
 100% 0%
38.21% (-22.76% 🔻)
🔴
... / worker.dynamic-ds.service.ts
44.44% (-17.78% 🔻)
 100% 0%
44.44% (-17.78% 🔻)
🔴
... / worker.service.ts
20.35% (-24.29% 🔻)
 100% 0%
20.35% (-24.29% 🔻)
🟢
... / worker.store.service.ts
80% (-2.61% 🔻)
 100% 50%
80% (-2.61% 🔻)
🔴
... / worker.ts
41.82% (-0.63% 🔻)
 100% 0%
41.82% (-0.63% 🔻)
🔴
... / worker.unfinalizedBlocks.service.ts
33.33% (-66.67% 🔻)
 100%
0% (-100% 🔻)
33.33% (-66.67% 🔻)
🔴
... / logger.ts
44.74% (-19.74% 🔻)
 33.33%
40% (+20% 🔼)
44.74% (-19.74% 🔻)
🟡
... / meta.service.ts
68.57% (-0.95% 🔻)
100% (+20% 🔼)
36.36% (-3.64% 🔻)
68.57% (-0.95% 🔻)
🔴
... / forceClean.service.ts
22.08% (-4.24% 🔻)
 100% 0%
22.08% (-4.24% 🔻)
🔴
... / reindex.service.ts
14.73% (-18.6% 🔻)
 100% 0%
14.73% (-18.6% 🔻)
🟡
... / autoQueue.ts
60.3% (-28.09% 🔻)
 85.11%
73.08% (-6.09% 🔻)
60.3% (-28.09% 🔻)
🟢
... / blockHeightMap.ts
87.04% (-5.56% 🔻)
 100%
77.78% (-9.72% 🔻)
87.04% (-5.56% 🔻)
🟡
... / blocks.ts
77.78% (-22.22% 🔻)
 88.89%
66.67% (-33.33% 🔻)
77.78% (-22.22% 🔻)
🟢
... / promise.ts
86.44% (-5.32% 🔻)
100% (+13.64% 🔼)
71.43% (-14.29% 🔻)
86.44% (-5.32% 🔻)
🔴
... / yargs.ts
44.38% (-1.11% 🔻)
 100% 14.29%
44.38% (-1.11% 🔻)
🟢
... / SubqueryProject.ts
95.38% (-0.14% 🔻)
83.33% (+0.98% 🔼)
87.5% (+1.79% 🔼)
95.38% (-0.14% 🔻)
🟡
... / apiPromise.connection.ts
77.08% (+8% 🔼)
50% (-30% 🔻)
62.5% (+19.64% 🔼)
77.08% (+8% 🔼)
🔴
... / worker-block-dispatcher.service.ts
24.64% (-12.32% 🔻)
 100% 0%
24.64% (-12.32% 🔻)
🟢
... / substrateDictionary.service.ts
88.35% (-2.22% 🔻)
41.67% (-31.06% 🔻)
100% (+20% 🔼)
88.35% (-2.22% 🔻)
🟡
... / substrateDictionaryV1.ts
63.46% (-22.03% 🔻)
70.27% (+0.5% 🔼)
53.85% (-29.49% 🔻)
63.46% (-22.03% 🔻)
🟡
... / substrateDictionaryV2.ts
70.79% (-4.72% 🔻)
50% (-25% 🔻)
 33.33%
70.79% (-4.72% 🔻)
🟢
... / fetch.module.ts
90% (-1.88% 🔻)
50% (-25% 🔻)
 100%
90% (-1.88% 🔻)
🔴
... / indexer.manager.ts
56.35% (-1.2% 🔻)
 100%
20% (+10.91% 🔼)
56.35% (-1.2% 🔻)
🟢
... / runtimeService.ts
94.29% (+2.08% 🔼)
81.82% (-7.07% 🔻)
100% (+20% 🔼)
94.29% (+2.08% 🔼)
🔴
... / http.ts
49.03% (-30.89% 🔻)
 40%
28.57% (-2.2% 🔻)
49.03% (-30.89% 🔻)
🟢
... / project.ts
88.81% (-0.08% 🔻)
 68.18% 87.5%
88.81% (-0.08% 🔻)
🟢
... / buffer.ts
90.24% (-9.76% 🔻)
90.91% (-9.09% 🔻)
85.71% (+1.5% 🔼)
90.24% (-9.76% 🔻)
🟢
... / builder.ts
 92.77%
82.14% (-0.62% 🔻)
 100% 92.77%
🟡
... / logger.ts
69.01% (-0.59% 🔻)
50% (-5% 🔻)
78.57% (+3.57% 🔼)
69.01% (-0.59% 🔻)

Test suite run failed

Failed tests: 17/546. Failed suites: 5/98. 
  ● Dictionary V1 › coreDictionary › set startHeight of this dictionary

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › coreDictionary › validateChainMeta and useDictionary

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › coreDictionary › validate dictionary with a height

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › coreDictionary › able to build queryEntryMap

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › coreDictionary › can use scoped dictionary query

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › coreDictionary › able to getDicitonaryQueryEntries

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › get metadata

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › init metadata and get metadata

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › return dictionary query result

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › should return undefined startblock height greater than dictionary last processed height

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)

  ● Dictionary V1 › should use metadata last process height at end of query height

    Dictionary metadata query timeout in 10 seconds. Please increase --dictionary-timeout.

      11 | export async function timeout<T>(promise: Promise<T>, sec: number, errMsg = 'timeout'): Promise<T> {
      12 |   // so we can have a more comprehensive error stack
    > 13 |   const err = new Error(errMsg);
         |               ^
      14 |   let timeout: NodeJS.Timeout;
      15 |   return Promise.race([
      16 |     promise.then(

      at timeout (packages/node-core/src/utils/promise.ts:13:15)
      at TestDictionaryV1.init (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.ts:56:33)
      at prepareDictionary (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:50:29)
      at Object.<anonymous> (packages/node-core/src/indexer/dictionary/v1/dictionaryV1.spec.ts:59:24)


  ● Substrate DictionaryService › should return all specVersion

    TypeError: Cannot read properties of undefined (reading 'length')

      55 |     const specVersions = await dictionaryService.getSpecVersions();
      56 |
    > 57 |     expect(specVersions.length).toBeGreaterThan(0);
         |                         ^
      58 |     dictionaryService.onApplicationShutdown();
      59 |   }, 50000);
      60 | });

      at Object.<anonymous> (packages/node/src/indexer/dictionary/v1/substrateDictionaryV1.spec.ts:57:25)


  ● Codegen can generate schema › Should dedupe enums

    ENOENT: no such file or directory, open '/home/runner/work/subql/subql/packages/cli/test/schemaTest/src/types/models/foo.ts'




  ● Cli publish › should upload appropriate project to IPFS

    Publish project to default IPFS failed

      172 |     const results = ipfsWrite.addAll(contents, {pin: true, cidVersion: 0, wrapWithDirectory: isMultichain});
      173 |     for await (const result of results) {
    > 174 |       fileCidMap.set(result.path, result.cid.toString());
          |               ^
      175 |
      176 |       await ipfsWrite.pin.remote.add(result.cid, {service: PIN_SERVICE}).catch((e) => {
      177 |         console.warn(

      at packages/cli/src/controller/publish-controller.ts:174:15
          at async Promise.all (index 0)
      at async uploadFile (packages/cli/src/controller/publish-controller.ts:177:30)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:100:26)
      at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
          at async Promise.all (index 3)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
          at async Promise.all (index 0)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:91:17)
      at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
          at async Promise.all (index 5)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
      at async uploadToIpfs (packages/cli/src/controller/publish-controller.ts:70:28)
      at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:33:21)

    Cause:
    HTTPError: <html>
    <head><title>403 Forbidden</title></head>
    <body>
    <center><h1>403 Forbidden</h1></center>
    <hr><center>nginx/1.17.7</center>
    </body>
    </html>

      175 |
      176 |       await ipfsWrite.pin.remote.add(result.cid, {service: PIN_SERVICE}).catch((e) => {
    > 177 |         console.warn(
          |                      ^
      178 |           `Failed to pin file ${result.path}. There might be problems with this file being accessible later. ${e}`
      179 |         );
      180 |       });

      at Object.errorHandler [as handleError] (node_modules/ipfs-http-client/cjs/src/lib/core.js:84:15)
      at async Client.fetch (node_modules/ipfs-http-client/node_modules/ipfs-utils/src/http.js:161:9)
      at async addAll (node_modules/ipfs-http-client/cjs/src/add-all.js:21:17)
      at async Object.last [as default] (node_modules/it-last/index.js:13:20)
      at async Object.add (node_modules/ipfs-http-client/cjs/src/add.js:18:14)
          at async Promise.all (index 0)
      at async uploadFile (packages/cli/src/controller/publish-controller.ts:177:30)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:100:26)
      at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
          at async Promise.all (index 3)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
          at async Promise.all (index 0)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:91:17)
      at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
          at async Promise.all (index 5)
      at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
      at async uploadToIpfs (packages/cli/src/controller/publish-controller.ts:70:28)
      at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:33:21)


  ● Intergration test - Publish › overwrites any exisiting CID files

    thrown: "Exceeded timeout of 300000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      28 |   it('overwrites any exisiting CID files', async () => {
      29 |     const initCID = 'QmWLxg7xV7ZWUyc7ZxZ8XuQQ7NmH8WQGXzg7VZ3QQNqF-testing';
    > 30 |     const cidFilePath = path.resolve(projectDir, '.project-cid');
         |     ^
      31 |     await fs.promises.writeFile(cidFilePath, initCID);
      32 |     await Publish.run(['-f', projectDir, '-o']);
      33 |     const cidValue = await fs.promises.readFile(cidFilePath, 'utf8');

      at packages/cli/src/commands/publish.test.ts:30:5
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)

  ● Intergration test - Publish › create ipfsCID file stored in local with dictiory path

    thrown: "Exceeded timeout of 300000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      36 |
      37 |   it('create ipfsCID file stored in local with dictiory path', async () => {
    > 38 |     await Publish.run(['-f', projectDir]);
         |     ^
      39 |     const cidFile = path.resolve(projectDir, '.project-cid');
      40 |     const fileExists = fs.existsSync(cidFile);
      41 |     const IPFScontent = await fs.promises.readFile(cidFile, 'utf8');

      at packages/cli/src/commands/publish.test.ts:38:5
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)

  ● Intergration test - Publish › file name consistent with manfiest file name, if -f <manifest path> is used

    thrown: "Exceeded timeout of 300000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      45 |
      46 |   // Run this last because it modifies the project
    > 47 |   it('file name consistent with manfiest file name, if -f <manifest path> is used', async () => {
         |     ^
      48 |     const manifestPath = path.resolve(projectDir, 'project.yaml');
      49 |     const testManifestPath = path.resolve(projectDir, 'test.yaml');
      50 |     fs.renameSync(manifestPath, testManifestPath);

      at packages/cli/src/commands/publish.test.ts:47:5
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)

Report generated by 🧪jest coverage report action from 81ca197

@yoozo yoozo requested review from stwiname and jiqiang90 and removed request for stwiname June 13, 2024 08:23
stwiname
stwiname reviewed Jun 16, 2024
View reviewed changes
packages/query/src/configure/configure.module.ts Outdated
Comment on lines 17 to 18
} catch (e) {
if (JSON.stringify(e.message).includes(CONNECTION_SSL_ERROR_REGEX)) {
if (JSON.stringify((e as Error).message).includes(CONNECTION_SSL_ERROR_REGEX)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern we have been using is } catch (e: any) {, I think it would be good to retain that pattern

packages/query/src/configure/x-postgraphile/debugClient.ts Outdated
Comment on lines 104 to 105
if (pgClient._explainResults) {
pgClient._explainResults.forEach(({query, values}: {query: string; values?: any[]}) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just use optional chaining here

packages/query/src/graphql/graphql.module.ts Outdated
Comment on lines 45 to 46
private apolloServer!: ApolloServer;
private dbType!: SUPPORT_DB;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding ! can you please use private getters/setters that have an assertion.

Here's an example https://github.com/subquery/subql/blob/main/packages/node-core/src/indexer/store.service.ts#L76-L78

packages/query/src/graphql/graphql.module.ts Outdated
@@ -133,9 +132,12 @@ export class GraphqlModule implements OnModuleInit, OnModuleDestroy {
const pluginHook = makePluginHook([PgPubSub]);
// Must be called manually to init PgPubSub since we're using Apollo Server and not postgraphile
options = pluginHook('postgraphile:options', options, {pgPool: this.pgPool});
options.replaceAllPlugins.push(PgSubscriptionPlugin);
options.replaceAllPlugins = options.replaceAllPlugins || [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newish feature is ??=

Suggested change
options.replaceAllPlugins = options.replaceAllPlugins || [];
options.replaceAllPlugins ??= [];

packages/query/tsconfig.json Outdated
@@ -6,7 +6,8 @@
"tsBuildInfoFile": "dist/.tsbuildinfo",
"rootDir": "src",
"outDir": "./dist",
"lib": ["dom"]
"lib": ["dom"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try removing this line and see if it produces any errors. The target for this isn't dom

@yoozo yoozo changed the base branch from main to strict-utils-types June 17, 2024 09:07
stwiname
stwiname reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, same as the other PR, needs a changelog and PR template filled out

@yoozo
Copy link
Collaborator Author

yoozo commented Jun 18, 2024

Modified

@yoozo yoozo merged commit 48e4c3f into strict-utils-types Jun 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stwiname stwiname stwiname left review comments

@jiqiang90 jiqiang90 Awaiting requested review from jiqiang90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoozo @stwiname