Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entryScript from datasources #2292

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Remove entryScript from datasources #2292

merged 2 commits into from
Mar 7, 2024

Conversation

stwiname
Copy link
Collaborator

@stwiname stwiname commented Mar 7, 2024

Description

Fixes a memory leak with workers caused by all datasources having the utf8 string of the js code. This was exacerbated when having a large number of datasources/dynamic datasources.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@stwiname stwiname merged commit f4f2cd2 into main Mar 7, 2024
1 of 2 checks passed
@stwiname stwiname deleted the fix-worker-memory-leak branch March 21, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants