[Java] Rename class scopes #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes scope of classes to `support.class`. Java decided to use `storage.type.class` as `support` scopes are said to be used for types provided by (standard) libraries only. Thus `storage.type` would be the scope for all user defined data types. The truth according to TextMate's is exactly vice versa. `storage.type` is meant for basic builtin data types of a language, such as `int`, `char`, ... `support.class`, `support.type`, ... however are meant for all kinds of custom or user defined data types - not only those from standard libraries. As such it makes very much sense most (all) other syntaxes use `support.class` for `ClassTypes`. This commit intents to make Java follow those rules, too, again.
jfcherng
approved these changes
May 13, 2023
FichteFoll
approved these changes
May 13, 2023
There was a problem hiding this comment.
I did find it a little weird that you went this road with Java but it didn't bother me after trying it out for a while. In the end, both are fine for me, but since Java is in the overwhelming minority, it makes sense to align Java with the others for now until we maybe find another solution do this (see #1842).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to change scope of classes to
support.class.Java decided to use
storage.type.classassupportscopes are said to be used for types provided by (standard) libraries only. Thusstorage.typewould be the scope for all user defined data types.The truth according to TextMate's is exactly vice versa.
storage.typeis meant for basic builtin data types of a language, such asint,char, ...support.class,support.type, ... however are meant for all kinds of custom or user defined data types - not only those from standard libraries.As such it makes very much sense most (all) other syntaxes use
support.classforClassTypes.This commit intents to make Java follow those rules, too, again.