Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] More small tweaks to type matching #3590

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

FichteFoll
Copy link
Collaborator

  • Fixes highlighting of unknown generic types
  • Adds stacking of storage.type under support.type

@deathaxe
Copy link
Collaborator

Why stacking two type scopes?

With a closer and careful look at original TextMate scope naming guidelines storage.type is meant for any basic builtin data type, such as int, class, ..., while support.type is meant for any kind of library, 3rd-party or user defined data type.

We already abused that a bit by introducing keyword.declaration and limiting support scope to standard library like types.

I wouldn't start stacking those different kinds of data type scopes.

@keith-hall
Copy link
Collaborator

I was wondering the same thing myself :)

@FichteFoll
Copy link
Collaborator Author

Stacking was primarily inspired from the discussion at #1842 (comment). The discussion never reached a conclusion though and I also see that this sort of stacking is not used elsewhere, so I will drop the commit.

@deathaxe deathaxe merged commit 0c25de5 into sublimehq:master Dec 3, 2022
@FichteFoll FichteFoll deleted the pr/rust/types2 branch December 3, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants