[Haskell] Fix qualified import alias scope name #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ... 1. scopes an imported namespace's alias name `variable.namespace` as it doesn't introduce/declare anything new but another name for the imported module. 2. escapes from `import` context as early as possible by using more strictly sub-contexts which enforce certain order of terms to reduce risk of failing to highlight following expressions correctly.
jrappen
approved these changes
Apr 5, 2022
michaelblyons
approved these changes
Apr 5, 2022
jfcherng
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3227 (comment)
This commit ...
variable.namespaceasit doesn't introduce/declare anything new but another name for the
imported module.
importcontext as early as possible by using morestrictly sub-contexts which enforce certain order of terms to reduce
risk of failing to highlight following expressions correctly.