[Python] Fix debugging f-string replacements #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: sublimehq#3216 This commit ... 1. uses multi-push to not push into python expression context twice. see: https://docs.python.org/3.6/reference/lexical_analysis.html#f-strings 2. adds requested support for surrounding whitespace of `=` debug modifier. 3. adds named contexts and re-uses common modifier patterns in both f-string contexts.
keith-hall
approved these changes
Jan 27, 2022
jfcherng
approved these changes
Jan 28, 2022
FichteFoll
approved these changes
Jan 28, 2022
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
Fixes: sublimehq#3216 This commit ... 1. uses multi-push to not push into python expression context twice. see: https://docs.python.org/3.6/reference/lexical_analysis.html#f-strings 2. adds requested support for surrounding whitespace of `=` debug modifier. 3. adds named contexts and re-uses common modifier patterns in both f-string contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3216