[Rust] Tweak tmPreferences #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames all tmPreferences files to match the common naming scheme used in all other packages.
This commit... 1. removes the following entries, which are defined in Default/Symbol List.tmPreferences: - `entity.name.enum` - `entity.name.function` - `entity.name.type` 2. adds: - `entity.name.constant.rust` - `entity.name.union` 3. adds a simple test for each symbol kind
keith-hall
approved these changes
Jan 10, 2022
|
There's an RFC for the scoping and indexing of constants at #458 |
|
I can't find something about indexing in it. What I have in mind is variables not to be scoped in general as those would cause too much noise. Rust scopes constants |
jrappen
approved these changes
Jan 11, 2022
michaelblyons
approved these changes
Jan 11, 2022
varungandhi-src
pushed a commit
to sourcegraph/Packages
that referenced
this pull request
Jan 14, 2022
* [Rust] Rename tmPreferences files This commit renames all tmPreferences files to match the common naming scheme used in all other packages. * [Rust] Remove `name` field from tmPreferences files * [Rust] Tweak Symbol List This commit... 1. removes the following entries, which are defined in Default/Symbol List.tmPreferences: - `entity.name.enum` - `entity.name.function` - `entity.name.type` 2. adds: - `entity.name.constant.rust` - `entity.name.union` 3. adds a simple test for each symbol kind
FichteFoll
reviewed
Jan 20, 2022
Comment on lines
+15
to
+23
| struct MyStruct { | ||
| // @@@@@@@@ definition | ||
|
|
||
| const A = 0; | ||
| // @ definition | ||
|
|
||
| fn bar() {} | ||
| // @@@ definition | ||
| } |
There was a problem hiding this comment.
This is actually invalid syntax. What it should be is:
struct MyStruct {}
// @@@@@@@@ definition
impl MyStruct {
const A: i32 = 0;
// @ definition
fn bar() {}
// @@@ definition
}
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [Rust] Rename tmPreferences files This commit renames all tmPreferences files to match the common naming scheme used in all other packages. * [Rust] Remove `name` field from tmPreferences files * [Rust] Tweak Symbol List This commit... 1. removes the following entries, which are defined in Default/Symbol List.tmPreferences: - `entity.name.enum` - `entity.name.function` - `entity.name.type` 2. adds: - `entity.name.constant.rust` - `entity.name.union` 3. adds a simple test for each symbol kind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies some changes to Rust's tmPreferences to re-align them with the other packages.
We might want to discuss, whether we want to add
entity.name.constant.rustto the symbol list as requested by #3193 as it would cause all global and local constant declarations to be indexed.