Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .DS_Store file that made its way into the repo #2716

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Remove .DS_Store file that made its way into the repo #2716

merged 1 commit into from
Feb 11, 2021

Conversation

frou
Copy link
Contributor

@frou frou commented Feb 11, 2021

It got committed as part of this: #2645

Thom1729
Thom1729 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@Thom1729 Thom1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MY BAD

@frou
Copy link
Contributor Author

frou commented Feb 11, 2021

Hehe, I only noticed due to having a launchd job that runs over my entire filesystem and deletes every .DS_Store (except for ~/.DS_Store). So a deletion ready to be committed showed up in git status

@wbond wbond merged commit e3f486c into sublimehq:master Feb 11, 2021
@wbond
Copy link
Member

wbond commented Feb 11, 2021

Thanks!

@FichteFoll
Copy link
Collaborator

I suggest everyone on mac to add .DS_Store to their global gitignore, btw.

mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
@frou @mitranim
[JavaScript] Remove .DS_Store file (sublimehq#2716)
8730961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thom1729 Thom1729 Thom1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frou @wbond @FichteFoll @Thom1729