-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add net8 and net7 support #31
fix: add net8 and net7 support #31
Conversation
Hi @starcraft66 @Gcaya @asimmon @decarufe and sorry to tag you like this but this tool seems to be heavily used (downloaded 700 times per day) even though it's unlisted. It also has 2 published spinoffs to add support for .NET7. Is there any interest from Workleap to relist this nuget or give the ownership to me or someone else to support it? |
@elonmallin Thank you for your contribution. I did the .NET 7 upgrade last year. Unfortunately, nobody from maintainers of this repo ever replied so far. Again, as I need it in my CI environment, I've pushed a version to nuget.org. Here's what I did:
And here it is: https://www.nuget.org/packages/dotnet-certificate-tool-net8/1.0.0 |
Thanks @dradovic ! Are you interested in maintaining your version? Might be nice with a non framework specific name in that case and making a public repo for it :) |
I'm not necessarily keen to become a maintainer of this project as I'm not acquainted with its actual logic. I still hope that somebody of the original maintainers will step up or somebody else (you? ;). But who knows. If we bump our heads against a .NET upgrade that requires more than just adjusting some .NET tags, we need a new maintained public repo. |
@gsoft-inc @yohanb @patricklafrance @decarufe will you approve this PR? Thanks! |
@elonmallin @yohanb @ivanpaulovich @shoshins can you please merge the PR |
Hi @elonmallin the docker image used in your PR seems to be wrong/outdated. Can you please change it to the one suggested above? |
This is a widely used tool, are there plans to merge this PR? |
Hello, can you merge this PR as we need it to upgrade our environments? |
Hi, I'd like to add .net8 and .net7 support to this great tool. This PR is the same as the last merged PR which added .net6.
What do you think about merging this when .net8 is released on 2023-11-14?