Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add net8 and net7 support #31

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

elonmallin
Copy link
Collaborator

Hi, I'd like to add .net8 and .net7 support to this great tool. This PR is the same as the last merged PR which added .net6.

What do you think about merging this when .net8 is released on 2023-11-14?

@elonmallin
Copy link
Collaborator Author

Hi @starcraft66 @Gcaya @asimmon @decarufe and sorry to tag you like this but this tool seems to be heavily used (downloaded 700 times per day) even though it's unlisted. It also has 2 published spinoffs to add support for .NET7.

Is there any interest from Workleap to relist this nuget or give the ownership to me or someone else to support it?

@dradovic
Copy link
Contributor

dradovic commented Nov 16, 2023

@elonmallin Thank you for your contribution. I did the .NET 7 upgrade last year. Unfortunately, nobody from maintainers of this repo ever replied so far.

Again, as I need it in my CI environment, I've pushed a version to nuget.org. Here's what I did:

  1. Cloned your repo from https://github.com/elonmallin/dotnet-certificate-tool.git
  2. Adjusted package ID to <PackageId>dotnet-certificate-tool-net8</PackageId> to not have a conflict on nuget.org
  3. dotnet build -c Release
  4. dotnet pack -c Release GSoft.CertificateTool.csproj
  5. Uploaded to nuget.org

And here it is: https://www.nuget.org/packages/dotnet-certificate-tool-net8/1.0.0

@dradovic dradovic mentioned this pull request Nov 16, 2023
@elonmallin
Copy link
Collaborator Author

Thanks @dradovic !

Are you interested in maintaining your version? Might be nice with a non framework specific name in that case and making a public repo for it :)

@dradovic
Copy link
Contributor

I'm not necessarily keen to become a maintainer of this project as I'm not acquainted with its actual logic. I still hope that somebody of the original maintainers will step up or somebody else (you? ;).

But who knows. If we bump our heads against a .NET upgrade that requires more than just adjusting some .NET tags, we need a new maintained public repo.

@SoyDiego
Copy link

@gsoft-inc @yohanb @patricklafrance @decarufe will you approve this PR?

Thanks!

@stylianosnicoletti
Copy link
Owner

stylianosnicoletti commented Feb 15, 2024

@elonmallin @yohanb @ivanpaulovich @shoshins can you please merge the PR

docker-example/Dockerfile Show resolved Hide resolved
docker-example/Dockerfile Show resolved Hide resolved
@stylianosnicoletti
Copy link
Owner

Hi @elonmallin the docker image used in your PR seems to be wrong/outdated. Can you please change it to the one suggested above?

@williamiss
Copy link

This is a widely used tool, are there plans to merge this PR?

@daphneSot
Copy link

Hello, can you merge this PR as we need it to upgrade our environments?

@decarufe
Copy link

@stylianosnicoletti stylianosnicoletti merged commit 0ef4ecf into stylianosnicoletti:master Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants