Fix and optimize position and dimension setting methods for frames #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In set-position, instead of delegating to the frame-x and frame-y setters, calculate the values in the method and call set-position again. This reduces method calls overall, especially to clients. + Fix (setf (frame-x tree-frame)) and (setf (frame-y tree-frame)) so that they translate their children in the correct direction
Compute the scale and shift of children at the same time so the we continue to use set-dimension and reduce the amount of configure calls to clients. I won't be 100% confident this is correct until I see it work, but I'm more confident than previously.
sdilts
force-pushed
the
fix/set-position-method
branch
from
4faf14f to
14ba9eb
Compare
sdilts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In set-position, instead of delegating to the frame-x and frame-y setters, calculate the values in the method and call set-position again. This reduces method calls overall, especially to clients.