This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I like this library since it's fast.
However, when using
mprpc
, you will see various warnings. That's why we've made improvements to makemprpc
more modern.Summary
Avoid PendingDeprecationWarning
For updating
msgpack
, I replacedmsgpack-python
withmsgpack
, which continues to be developed. Accordingly, this pull request no longer specifies the encoding of the string sent and received via MessagePack. These changes resolvePendingDeprecationWarning
.NOTE: Python 2 users may feel inconvenience about these changes. However, Python 2 is no longer supported from this year.
Avoid ResourceWarning
When the connection is terminated, the
RPCClient
class requires executing theclose
method explicitly. Otherwise, ResourceWarning is raised because the socket is still. For this reason, theRPCClient
class is modified to support thewith_statement
. Using thewith_statement
leads to avoid forgetting executing theclose
method.Avoid ImportWarning
On Python 3.7, using the C-language file generated by Old Cython raise
ImportWarning
. Thus, I regenerated c files by Cython 0.29.16 (currently, this version is the latest).Change support Python versions
I think stopping tests with Python 2.6 and Python 3.3 on Travis CI is better since Travis CI can not test with Python 2.6 and Python 3.3 by default.
On the other hand, I think supporting Python 3.6, 3.7, and 3.8 is better.
Appendix
Errors on mprpc 0.1.17
On Python 3.7, when I execute the command
$ python setup.py test
, various warnings occur as follows:Thank you for your consideration😊