Ensure correct JPEG2000 SIZ segment bounds check #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
force-pushed
the
j2k-siz-segment-bounds
branch
from
4970fc4 to
c6af00f
Compare
|
@farindk This is currently the only other (known) buffer overflow in libheif found via the libvips fuzzers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a possible improvement to the JPEG2000 SIZ segment bounds check introduced in 7bf1cdf to ensure the data is long enough to read out all of the components.
It also adds a sample file discovered via fuzz testing that will currently trigger a buffer overflow.