Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: initial upgrade to Catch2 version 3.3.2 #869

Closed
wants to merge 1 commit into from

Conversation

bradh
Copy link
Contributor

@bradh bradh commented May 19, 2023

This only does the "amalgamated" migration approach, rather than a proper static library. See https://github.com/catchorg/Catch2/blob/devel/docs/migrate-v2-to-v3.md#how-to-migrate-projects-from-v2-to-v3

@bradh
Copy link
Contributor Author

bradh commented May 19, 2023

The other approach to this would be a git submodule. However that does require a bit more work on the part of developers (for the submodule init or recurse etc).

@farindk
Copy link
Contributor

farindk commented May 22, 2023

Note: this will increase the minimum C++ version to C++14. Currently, it is C++11.
We have to check whether that is fine even for old distributions.

@bradh
Copy link
Contributor Author

bradh commented May 22, 2023

Note: this will increase the minimum C++ version to C++14. Currently, it is C++11. We have to check whether that is fine even for old distributions.

I had hoped it would only be needed to run tests. The C++14 support is default in gcc 6 and some of it is available back to later gcc 4 versions, per https://gcc.gnu.org/projects/cxx-status.html#cxx14

It might be marginal on RHEL 7, but RHEL 8 and derivatives would be fine.

@bradh bradh closed this Dec 10, 2023
@farindk farindk mentioned this pull request Nov 3, 2024
@farindk
Copy link
Contributor

farindk commented Nov 3, 2024

Since we are now using C++20, we can finally merge this. I have merged this and done the required changes in #1364 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants