Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case for uncompressed decoder advertisement #1347

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Oct 20, 2024

This shows that we are not advertising decoder support for uncompressed.

The base reason is that it checks for the compression type in the list of plugins, and there is no plugin for uncompressed decode. There is one for uncompressed encode.

This doesn't show up in the heif-dec example code, because it has a hard-coded response depending on compile time option for uncompressed.

I can see two ways forward:

  • add a dummy decoder plugin
  • add a special case (depending on compile time option for uncompressed) to heif_have_decoder_for_format().

@farindk your preference?

@bradh
Copy link
Contributor Author

bradh commented Oct 20, 2024

I added the special case for this proposal. Just seemed simpler and easier, not necessarily better.

@bradh bradh marked this pull request as ready for review October 20, 2024 03:10
@farindk farindk merged commit de623ee into strukturag:master Oct 20, 2024
35 checks passed
farindk added a commit that referenced this pull request Oct 20, 2024
@farindk
Copy link
Contributor

farindk commented Oct 20, 2024

I've changed it to a dummy decoder plugin because there are other API functions that did not list the uncompressed decoder (e.g. heif_get_decoder_descriptors()) and we also need an ID for it to be used in heif_decoding_options::decoder_id.

@bradh bradh deleted the uncompressed_in_api_2024-10-20 branch October 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants