Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: speculative build fix for AppVeyor #1341

Closed
wants to merge 1 commit into from

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Oct 16, 2024

Recent builds have failed, example https://ci.appveyor.com/project/strukturag/libheif/builds/50803252/job/9ra01vv6lfwrtjsj

This is a potential (possibly partial) fix.

@bradh
Copy link
Contributor Author

bradh commented Oct 16, 2024

Partial fix.

@farindk
Copy link
Contributor

farindk commented Oct 16, 2024

The main issue for windows is that the functions to scan the directory do not exist in Windows. Maybe we can replace it with std::filesystem.

@bradh
Copy link
Contributor Author

bradh commented Oct 16, 2024

The main issue for windows is that the functions to scan the directory do not exist in Windows. Maybe we can replace it with std::filesystem.

Looks like best option since we are already up to C++ 20.

@farindk
Copy link
Contributor

farindk commented Oct 16, 2024

Windows build works again using std::filesystem. The issue with Windows is still that file paths use wstring and POSIX uses UTF-8 string. I'm converting Windows strings to UTF-8, but I have not yet tested whether everything works with non-ascii characters.

@farindk farindk closed this Oct 16, 2024
@bradh bradh deleted the ci_win_2024-10-16 branch October 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants