extract stream decoding to Decoder classes #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
reviewed
Oct 1, 2024
CMakeLists.txt
Outdated
| @@ -243,7 +243,7 @@ endif() | |||
| plugin_option(OpenJPEG_ENCODER "OpenJPEG J2K encoder" OFF ON) | |||
| plugin_option(OpenJPEG_DECODER "OpenJPEG J2K decoder" OFF ON) | |||
| if (WITH_OpenJPEG_ENCODER OR WITH_OpenJPEG_DECODER) | |||
| find_package(OpenJPEG 2) | |||
| find_package(OpenJPEG) | |||
There was a problem hiding this comment.
I know why you do this (I do too), but probably not wanted in this PR.
There was a problem hiding this comment.
I think I'll have to put that on .gitignore. No matter how much care I take, sooner or later it slips through :-)
…orwards the call to the Decoder object
…essed_item_data()
…image data anymore and the locking should be in Box_iloc::read_data() anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move actual bitstream decoding into
Decoderclasses that can decode data irrespective where the data is located in the file.