uncompressed: update generic compression to current DAM 2 #1270
Conversation
|
Thanks. If you have larger changes in the coming days, can you please develop them against the I cannot merge |
| can_use_implied_offsets = false; | ||
| } | ||
| implied_offset += unit_info.unit_size; | ||
| while (unit_info.unit_offset >= (1ULL << unit_offset_nbbits)) { |
There was a problem hiding this comment.
clang-tidy says:
uncompressed_box.cc:476:43: error: The result of the left shift is undefined due to shifting by '64', which is greater or equal to the width of type 'unsigned long long' [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]
while (unit_info.unit_offset >= (1ULL << unit_offset_nbbits))
I think this is a false positive, but you may want to check too.
There was a problem hiding this comment.
Here is the link to the logical reasoning:
https://github.com/strukturag/libheif/actions/runs/10369014420/job/28703823871#step:6:521
There was a problem hiding this comment.
Now I see why this is wrong. The computation of unit_offset_nbbits is in a for-loop and leads to the error when it has reached 64bit in a previous iteration.
Please check the computation. Maybe it has to be outside the for-loop.
There was a problem hiding this comment.
I have an idea for a cleaner approach. Will update.
The big change is that offsets are now relative to the start of the data, not the start of the file. That requires new test data.
The box name also changes.