encoder_kvazaar.cc: Fix some memory leaks #1141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following memory leaks:
data
chunks are not freed in all cases after being appended to the encoder outputappend_chunk_data
throwing an exception (std::bad_alloc) would not free any of the kvazaar-structuresAt least the successful encoding case should be leak-free now: The address sanitizer does not report any leaks.
I did not test the exceptional cases - using unique_ptr this should be no different than the successful case.