use variable to set macOS compatible_version (#997)

strukturag · Oct 17, 2023 · 3168aa0 · kmilos · Oct 17, 2023 · farindk
1 parent f96f2fa
commit 3168aa0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2,6 +2,12 @@ cmake_minimum_required (VERSION 3.16.3) # Oldest Ubuntu LTS (20.04 currently)
 
 project(libheif LANGUAGES C CXX VERSION 1.17.0)
 
+# compatibility_version is never allowed to be decreased for any specific SONAME.
+# Libtool in the libheif-1.15.1 release had set it to 17.0.0, so we have to use this for the v1.x.y versions.
+# With v2.0.0, we can reset this to more closely follow the real version name, i.e. "2.0.0".
+# CMake 3.17.0 added "MACHO_COMPATIBILITY_VERSION", but we are currently stuck at cmake 3.16.3.
+set(MACOS_COMPATIBLE_VERSION "17.0.0")
+
 # https://cmake.org/cmake/help/v3.1/policy/CMP0054.html
 cmake_policy(VERSION 3.0...3.22)
 include(GNUInstallDirs)

diff --git a/libheif/CMakeLists.txt b/libheif/CMakeLists.txt
@@ -100,13 +100,10 @@ set_target_properties(heif
         VERSION ${PROJECT_VERSION}
         SOVERSION ${PROJECT_VERSION_MAJOR})
 
-# compatibility_version defaults to 1.0.0 and is never allowed to be
-# decreased for any specific SONAME. Libtool in the libheif-1.15.1
-# release had set it to 17.0.0, so force it higher here.
 if (APPLE)
     set_target_properties(heif
             PROPERTIES
-	    LINK_FLAGS "-Wl,-compatibility_version,18.0.0")
+	    LINK_FLAGS "-Wl,-compatibility_version,${MACOS_COMPATIBLE_VERSION}")
 endif ()
 
 target_compile_definitions(heif