remove pass-through method add_unci_item()

strukturag · Oct 14, 2024 · 1236f2f · 1236f2f
1 parent 0d4487b
commit 1236f2f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 19 deletions.
diff --git a/libheif/api/libheif/heif.cc b/libheif/api/libheif/heif.cc
@@ -3607,7 +3607,7 @@ struct heif_error heif_context_add_unci_image(struct heif_context* ctx,
 {
 #if WITH_UNCOMPRESSED_CODEC
   Result<std::shared_ptr<ImageItem_uncompressed>> unciImageResult;
-  unciImageResult = ctx->context->add_unci_item(parameters, encoding_options, prototype->image);
+  unciImageResult = ImageItem_uncompressed::add_unci_item(ctx->context.get(), parameters, encoding_options, prototype->image);
 
   if (unciImageResult.error != Error::Ok) {
     return unciImageResult.error.error_struct(ctx->context.get());

diff --git a/libheif/context.cc b/libheif/context.cc
@@ -1384,20 +1384,6 @@ Error HeifContext::add_tiled_image_tile(heif_item_id tild_id, uint32_t tile_x, u
 }
 
 
-Result<std::shared_ptr<ImageItem_uncompressed>> HeifContext::add_unci_item(const heif_unci_image_parameters* parameters,
-                                                                           const struct heif_encoding_options* encoding_options,
-                                                                           const std::shared_ptr<const HeifPixelImage>& prototype)
-{
-#if WITH_UNCOMPRESSED_CODEC
-  return ImageItem_uncompressed::add_unci_item(this, parameters, encoding_options, prototype);
-#else
-  return Error{heif_error_Unsupported_feature,
-               heif_suberror_Unspecified,
-               "support for uncompressed images has been disabled"};
-#endif
-}
-
-
 void HeifContext::set_primary_image(const std::shared_ptr<ImageItem>& image)
 {
   // update heif context

diff --git a/libheif/context.h b/libheif/context.h
@@ -146,10 +146,6 @@ class HeifContext : public ErrorBuffer
                              const std::shared_ptr<HeifPixelImage>& image,
                              struct heif_encoder* encoder);
 
-  Result<std::shared_ptr<ImageItem_uncompressed>> add_unci_item(const heif_unci_image_parameters* parameters,
-                                                                const struct heif_encoding_options* encoding_options,
-                                                                const std::shared_ptr<const HeifPixelImage>& prototype);
-
   void set_primary_image(const std::shared_ptr<ImageItem>& image);
 
   bool is_primary_image_set() const { return m_primary_image != nullptr; }