Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix install command #1242

Closed
wants to merge 5 commits into from

Conversation

sonofgibs
Copy link

go get resulted in undefined errors on my machine. Once I updated my Go version to 1.19 I got this handy message:
'go get' is no longer supported outside a module.
To build and install a command, use 'go install' with a version,
like 'go install example.com/cmd@latest'

So updated the documentation to match. 😄

Summary

Updated installation guidelines

Changes

Updated installation guidelines to adhere to Go 1.19 go get deprecation

Motivation

Simple but annoying to google, easy to fix

go install github.com/stretchr/testify@latest

Related issues

`go get` resulted in undefined errors on my machine. Once I updated my Go version to 1.19 I got this handy message:
'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'

So updated the documentation to match. 😄
Copy link
Collaborator

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we must just drop the GOPATH-mode version and show only the Go Modules one (go install).

@dolmen dolmen changed the title Updated Readme installation documentation README: fix install command Oct 30, 2023
@sonofgibs
Copy link
Author

sonofgibs commented Oct 31, 2023

drop the GOPATH-mode version and show only the Go Modules

PR has been updated, please re-review @dolmen

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Staying up-to-date' section must be fixed as well.

@sonofgibs sonofgibs closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants