web: add go to next/previous tab shortcut #7109
Open
+117
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01zulfi
force-pushed
the
feat/switch-tab-shortcut
branch
from
85ba203 to
66b7340
Compare
thecodrr
requested changes
Dec 20, 2024
Comment on lines
168
to
176
| handleKeyDown(_, event) { | ||
| if (event.ctrlKey && event.key === "ArrowRight") { | ||
| event.preventDefault(); | ||
| useEditorStore.getState().openNextSession("right"); | ||
| } | ||
| if (event.ctrlKey && event.key === "ArrowLeft") { | ||
| event.preventDefault(); | ||
| useEditorStore.getState().openNextSession("left"); | ||
| } |
There was a problem hiding this comment.
Not sure this is the right place to handle this. Also Ctrl + Arrow Keys are used for caret navigation so we can't use those.
There was a problem hiding this comment.
Nice catch on the Ctrl + Arrow shortcut. I've moved this shortcut to Ctrl + Alt + Arrow, let me know if this is okayy
Comment on lines
+459
to
+461
| if (isActive) { | ||
| activeTabRef.current = el; | ||
| } |
There was a problem hiding this comment.
No need to wrap this in a condition.
There was a problem hiding this comment.
Without the condition, the tab strip would scroll to the last tab regardless of the active tab position.
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
feat/switch-tab-shortcut
branch
from
66b7340 to
1f8dc53
Compare
01zulfi
commented
Dec 23, 2024
Comment on lines
+124
to
+139
| useEffect(() => { | ||
| const onKeyDown = (event: KeyboardEvent) => { | ||
| if (event.ctrlKey && event.altKey && event.key === "ArrowRight") { | ||
| event.preventDefault(); | ||
| useEditorStore.getState().openNextSession(); | ||
| } | ||
| if (event.ctrlKey && event.altKey && event.key === "ArrowLeft") { | ||
| event.preventDefault(); | ||
| useEditorStore.getState().openPreviousSession(); | ||
| } | ||
| }; | ||
| document.body.addEventListener("keydown", onKeyDown); | ||
| return () => { | ||
| document.body.removeEventListener("keydown", onKeyDown); | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
I've moved the onKeyDown handler for this keyboard shortcut here as I noticed that the readonly notes weren't handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi [email protected]