editor: fix backspace deleting formatting in list item (#6712) #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01zulfi
force-pushed
the
fix/list-formatting-backspace
branch
from
df193a5 to
fd36749
Compare
thecodrr
requested changes
Nov 15, 2024
packages/editor/src/extensions/list-item/tests/list-tem.test.ts
Outdated
Show resolved
Hide resolved
packages/editor/patches/@tiptap+extension-list-keymap+2.6.6.patch
Outdated
Show resolved
Hide resolved
01zulfi
force-pushed
the
fix/list-formatting-backspace
branch
from
fd36749 to
f391d2d
Compare
01zulfi
force-pushed
the
fix/list-formatting-backspace
branch
from
f391d2d to
fd9da99
Compare
thecodrr
requested changes
Nov 16, 2024
| } | ||
| + // if previous item is not a list (could be a paragraph in the current list item) | ||
| + // join to the same list item | ||
| + if (!hasListItemBefore(name, editor.state)) { |
There was a problem hiding this comment.
After some more testing, this is not going to work. It breaks in cases where you are backspacing in the first item of the list. This logic should be more robust to handle only the cases where we are backspacing in the second or later child inside a list item.
I also recommend adding tests for other cases:
- Backspacing at the start of the first list item
- Backspacing when there is a list right before the list item
It should handle all these cases correctly.
01zulfi
force-pushed
the
fix/list-formatting-backspace
branch
from
fd9da99 to
f90935e
Compare
thecodrr
approved these changes
Nov 19, 2024
packages/editor/src/extensions/list-item/tests/list-item.test.ts
Outdated
Show resolved
Hide resolved
packages/editor/src/extensions/list-item/tests/list-item.test.ts
Outdated
Show resolved
Hide resolved
packages/editor/src/extensions/list-item/tests/list-item.test.ts
Outdated
Show resolved
Hide resolved
…#6712) * fix hitting backspace inside the second (or next) p in list item deleted the formatting of the entire list item Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
fix/list-formatting-backspace
branch
from
f90935e to
645fe82
Compare
thecodrr
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6712