Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk(test): [NET-1385] Use DATAv2 instead of TestToken #2951

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Dec 17, 2024

The DATAv2Abi.json and DATAv2.d.ts files are copy-pasted from https://www.npmjs.com/package/@streamr/data-v2 (v1.0.3)

  • jq '.abi' ./artifacts/contracts/DATAv2.sol/DATAv2.json > DATAv2Abi.json`
  • cp ./typechain/contracts/DATAv2.d.ts . and manually added two comment lines to the top of the file

Future improvements

  • We could maybe import these directly form @streamr/data-v2 or from a new unified contract package (see ETH-7999)
    • currently all contract artifacts are manually copy-pasted
    • if we import from other packages, it is to good to extract only the ABI part of the JSON (e.g with jq like done here) to reduce the file size significantly (~48K -> ~20K)
  • We can simplify test token handling in operatorContractUtils

Copy link

linear bot commented Dec 17, 2024

@github-actions github-actions bot added the sdk label Dec 17, 2024
@teogeb teogeb requested a review from harbu December 17, 2024 12:49
@teogeb teogeb merged commit f5a05e9 into main Dec 17, 2024
24 checks passed
@teogeb teogeb deleted the sdk-use-datav2-instead-of-testtoken branch December 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants