Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli-tool): add binary support to subscribe #2948

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat(cli-tool): add binary support to subscribe #2948

merged 4 commits into from
Dec 20, 2024

Conversation

harbu
Copy link
Contributor

@harbu harbu commented Dec 13, 2024 •
edited
Loading

Summary

Add (or fix?) binary support to streamr stream subscribe. Output is printed as hexadecimal string instead of Buffer object.

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

@github-actions github-actions bot added the cli-tools Related to CLI Tools Package label Dec 13, 2024
@github-actions github-actions bot added the docs label Dec 13, 2024
@harbu harbu requested a review from teogeb December 20, 2024 11:06
harbu
harbu commented Dec 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@harbu harbu merged commit 06476ce into main Dec 20, 2024
24 checks passed
@harbu harbu deleted the add-binary-support-to-cli-subscribe branch December 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teogeb teogeb teogeb approved these changes

Assignees
No one assigned
Labels
cli-tools Related to CLI Tools Package docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbu @teogeb