ETH-795: Export chain-related types along with the config #923
Conversation
There was a problem hiding this comment.
problem with removing ""s from the rawConfig is now it's not JSON anymore. Even better would be to put it into a separate json file (which is valid JSON), then read from there and give correct types for typescript. We want non-JS/TS languages be able to read this config as well.
| @@ -1,462 +1,547 @@ | |||
| export const config = { | |||
There was a problem hiding this comment.
@jtakalai this wasn't JSON before already. What's your idea on moving forward?
- Do you want to expose
config.json? - Do you want to have a
config.jsonnext toconfig.jsso people can decide (or straight up copy-paste)?
lmk
Cheers
There was a problem hiding this comment.
@jtakalai thoughts?
There was a problem hiding this comment.
ideally there would be a config.json that maybe then gets processed into whatever works best for a Typescript NPM package?
| @@ -1,462 +1,547 @@ | |||
| export const config = { | |||
There was a problem hiding this comment.
ideally there would be a config.json that maybe then gets processed into whatever works best for a Typescript NPM package?
No description provided.