-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETH-794: IoTeX deployment #922
Draft
jtakalai
wants to merge
8
commits into
master
Choose a base branch
from
eth-794-deploy-streamr-contracts-to-iotex-chain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jtakalai
commented
Oct 30, 2024
•
edited
Loading
edited
- testnet deployment
- also touched up deployment scripts so that the testnet deployment went nicely in one go
- test the testnet deployment in hub, do a happy path manually.
- mainnet deployment
- test the testnet deployment in hub, do a happy path manually.
also touched up deployment scripts so that the testnet deployment went nicely in one go. Next up: figure out a way to test if the deployment works! At least add the network to hub and test a happy path manually.
jtakalai
force-pushed
the
eth-794-deploy-streamr-contracts-to-iotex-chain
branch
from
October 31, 2024 09:03
8d5a64c
to
cc6a330
Compare
…amr-contracts-to-iotex-chain # Conflicts: # packages/network-contracts/hardhat.config.ts # packages/network-contracts/tasks/copyFilesAfterCompilation.ts
ETH-794: IoTeX deployment
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.