StreamrConfig test #666
Merged
StreamrConfig test #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added custom errors and (near) 100% coverage. Will be actually 100% after ETH-617 and some kind of upgrading test
ETH-600 Policy modules and StreamrConfig full coverage
This is a good time to really think about the StreamrConfig setters; what kind of limitations they should have so that the values make sense. Also maybe clean up outdated comments :) |
commit oops
…ig-full-coverage # Conflicts: # packages/network-contracts/contracts/OperatorTokenomics/StreamrConfig.sol
samt1803
added a commit
that referenced
this pull request
Oct 4, 2023
…sorship * origin/master: build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) # Conflicts: # packages/network-contracts/contracts/OperatorTokenomics/StreamrConfig.sol # packages/network-contracts/test/hardhat/OperatorTokenomics/Sponsorship.test.ts
samt1803
added a commit
that referenced
this pull request
Oct 4, 2023
…s_value * origin/master: build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) Activate delegationPolicy and undelegationPolicy in _transfer (#658) feat: pay for slashing by burning operator's self-delegation (#657) Clean up tokenomics contract tests' imports (#664)
samt1803
added a commit
that referenced
this pull request
Oct 9, 2023
* master: (32 commits) ETH-618: plug the malicious sponsorship / repeated deliberate slashing hole (#682) one bugfix with empty queue, and improved test path coverage (#681) refactor: moving functions around (#680) ETH-627: upgradeability (#677) ETH-636: Take fisherman's reward from self-delegation (#679) ETH-610 meta-transactions using minimalForwarder (#672) ETH-625: Add locked stake and flag info to subgraph, ETH-633: real-time earnings calculation info to subgraph (#675) Operator further coverage (#673) fix: JSON in projects data Test cleanups (#676) Eth 623 add maxOperators value to subgraph (#668) Eth 624 add policy checks to factories (#669) build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) Activate delegationPolicy and undelegationPolicy in _transfer (#658) feat: pay for slashing by burning operator's self-delegation (#657) Clean up tokenomics contract tests' imports (#664) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added custom errors and (near) 100% coverage. Will be actually 100% after ETH-617 and some kind of upgrading test