ETH-617: Voter selection and pseudorandomness cleanup #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't mix type and object imports, from "ethers" we only get types; the utils we get from hardhat's version
don't mix type and object imports, from "ethers" we only get types; the utils we get from hardhat's version
…ndomness so much easier to get full reviewer sets :)
ETH-617 Voter selection
Voter selection should use the best randomness available in the network. Eth mainnet for instance has verifiable randomness in Add Add For tests, mockRandomnessSource that allows setting seed and next number lists. Modify tests to generate seeded+simple random numbers (always +1 the previous one?), to get full voter sets. Also get VoteKickPolicy to full coverage with better tests |
...though it's an error that's almost impossible to trigger in real setting (requires there are only 2 live operators in existence, of random oracle that picks only 2 in 20 tries)
… from "ethers" better just import from one place, and now it's hardhat (and its modified ethers)
also add tests for full coverage of VoteKickPolicy
now the error messages show token amounts instead of wei amounts
# Conflicts: # packages/network-contracts/test/hardhat/OperatorTokenomics/SponsorshipPolicies/VoteKickPolicy.test.ts # packages/network-contracts/test/hardhat/OperatorTokenomics/deployTestContracts.ts # packages/network-contracts/test/hardhat/OperatorTokenomics/setupSponsorships.ts # packages/network-contracts/test/hardhat/Registries/StreamRegistry.test.ts
it's now inlined in VoteKickPolicy. The interface really now exists for testing only, but MAYBE we'll be happy later it's there, just in case we find cheap and good randomness in polygon later. also fixed a bug in secondary reviewer selection if we really would select lots of reviewers (more than 32), just use a dynamic-size memory array.
samt1803
approved these changes
Oct 2, 2023
packages/network-contracts/contracts/OperatorTokenomics/SponsorshipPolicies/VoteKickPolicy.sol
Outdated
Show resolved
Hide resolved
packages/network-contracts/contracts/OperatorTokenomics/SponsorshipPolicies/VoteKickPolicy.sol
Outdated
Show resolved
Hide resolved
samt1803
added a commit
that referenced
this pull request
Oct 4, 2023
…sorship * origin/master: build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) # Conflicts: # packages/network-contracts/contracts/OperatorTokenomics/StreamrConfig.sol # packages/network-contracts/test/hardhat/OperatorTokenomics/Sponsorship.test.ts
samt1803
added a commit
that referenced
this pull request
Oct 4, 2023
…s_value * origin/master: build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) Activate delegationPolicy and undelegationPolicy in _transfer (#658) feat: pay for slashing by burning operator's self-delegation (#657) Clean up tokenomics contract tests' imports (#664)
samt1803
added a commit
that referenced
this pull request
Oct 9, 2023
* master: (32 commits) ETH-618: plug the malicious sponsorship / repeated deliberate slashing hole (#682) one bugfix with empty queue, and improved test path coverage (#681) refactor: moving functions around (#680) ETH-627: upgradeability (#677) ETH-636: Take fisherman's reward from self-delegation (#679) ETH-610 meta-transactions using minimalForwarder (#672) ETH-625: Add locked stake and flag info to subgraph, ETH-633: real-time earnings calculation info to subgraph (#675) Operator further coverage (#673) fix: JSON in projects data Test cleanups (#676) Eth 623 add maxOperators value to subgraph (#668) Eth 624 add policy checks to factories (#669) build: generate function selector list to selectors.txt (#671) ETH-293: Added numeric precision to StakeWeightedAllocationPolicy (#670) test: add a longer "scenario" test to Sponsorship (#667) StreamrConfig test (#666) ETH-617: Voter selection and pseudorandomness cleanup (#665) Activate delegationPolicy and undelegationPolicy in _transfer (#658) feat: pay for slashing by burning operator's self-delegation (#657) Clean up tokenomics contract tests' imports (#664) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pseudorandomness works precisely like before (combine the slowly changing seed with keccak hashing), except now it can generate more pseudorandomness if number of selection iterations is higher
Thanks to coverage work, found and fixed an accounting bug in Sponsorship when flagger had left on a KICK result resolution. VoteKickPolicy coverage is now 100%.
Includes also #664 so might be good idea to merge that first to clean up the diff