Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature to provide imagePullSecrets and imagePullPolicy to runn… #791

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

moweonlee
Copy link
Contributor

Motivation

While working with FunctionMesh, we observed that the runner image could only be configured by specifying its repository. In our intranet environment, where all Docker images are used privately, it is essential to always define ImagePullSecrets.

This modification was aimed at ensuring that ImagePullSecrets and ImagePullPolicy can also be specified when downloading the modified runnerImage.

Additionally, we aligned this update with the existing functionality by placing the base runner image configuration within the values.yaml file of the Function Controller, maintaining consistency with the current setup.

Modifications

The modification ensures that when the FunctionMesh Controller uses the Kubernetes library to create StatefulSets for Functions, Sinks, and Sources, the ImagePullSecrets and ImagePullPolicy configurations are properly propagated to the associated POD settings.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

  • To validate this feature, we deployed the FunctionMesh Controller directly on our existing Pulsar cluster and conducted various tests to ensure its functionality.
  • We verified that the FunctionMesh Controller correctly applies the ImagePullSecret and ImagePullPolicy configurations for the runner and confirmed that there were no issues with other core functionalities. This was validated by building and testing both the Master Branch and branch-0.22.

Documentation

Check the box below.

Need to update docs?

  • doc-required

I think following README.md file should me modified to provide information about runner image configuration

@moweonlee moweonlee requested review from nlu90, freeznet and a team as code owners November 14, 2024 08:30
@github-actions github-actions bot added the doc-required This pr needs a document label Nov 14, 2024
@jiangpengcheng jiangpengcheng merged commit de6bfed into streamnative:master Nov 22, 2024
14 checks passed
@moweonlee moweonlee deleted the feat/runner branch November 22, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants