added feature to provide imagePullSecrets and imagePullPolicy to runn… #791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working with FunctionMesh, we observed that the runner image could only be configured by specifying its repository. In our intranet environment, where all Docker images are used privately, it is essential to always define ImagePullSecrets.
This modification was aimed at ensuring that ImagePullSecrets and ImagePullPolicy can also be specified when downloading the modified runnerImage.
Additionally, we aligned this update with the existing functionality by placing the base runner image configuration within the values.yaml file of the Function Controller, maintaining consistency with the current setup.
Modifications
The modification ensures that when the FunctionMesh Controller uses the Kubernetes library to create StatefulSets for Functions, Sinks, and Sources, the ImagePullSecrets and ImagePullPolicy configurations are properly propagated to the associated POD settings.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Documentation
Check the box below.
Need to update docs?
doc-required
I think following README.md file should me modified to provide information about runner image configuration