Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support special resource unit for VPA #748

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jiangpengcheng
Copy link
Member

@jiangpengcheng jiangpengcheng commented May 6, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

  1. the ratio of CPU and Memory should keep the same, e.g. if the cpu is increased to 400m, the memory also needs to increase to 1600Mi
  2. the resource must increase at least 200m and 800Mi, e.g. if the cpu should be 211m, we need to increase it to 400m

but with the default vpa updater, we cannot do that, so create this PR to fit for our charging model

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners May 6, 2024 02:32
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 6, 2024
@illegalnumbers
Copy link
Contributor

I took a look at this change and it seemed straightforward to me. I don't have a lot of context on this though, @freeznet or @nlu90 would be better to approve it. Also, the unit tests are still failing.

freeznet
freeznet previously approved these changes May 8, 2024
@freeznet freeznet added this to the 2024-04 v0.21.0 milestone May 8, 2024
freeznet
freeznet previously approved these changes May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants