Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autorecovery datadog annotation bug #1189

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Oct 24, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from a team as code owners October 24, 2024 02:43
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 24, 2024
Copy link

@Knnamadi Knnamadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dpappa dpappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciiiii ciiiii merged commit a2ca2d8 into master Nov 8, 2024
3 checks passed
@ciiiii ciiiii deleted the fix-autorecovery-dd branch November 8, 2024 16:00
ericsyh added a commit that referenced this pull request Nov 22, 2024
Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit a2ca2d8)
ericsyh added a commit that referenced this pull request Nov 22, 2024
Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit a2ca2d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants