Replace presto with trino #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaalsn
force-pushed
the
replace-presto-with-trino
branch
from
4cc440f
to
dd808bb
Compare
ericsyh
previously approved these changes
Nov 28, 2023
ericsyh
approved these changes
Dec 1, 2023
ericsyh
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Replace presto with trino * Run sql-worker pod with root user * Remove internal addr of node * Add header of health check * Change internal addr to pod ip of health check (cherry picked from commit d4c6a55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the pulsar image, presto is named trino. We need to adapt the related charts conf.
Modifications
trinoconf path.node.propertiesnode.internal-addressVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)
Test SQL query pass