Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datadog annotations for autorecovery #1127

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Nov 20, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from sijie and a team as code owners November 20, 2023 02:43
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 20, 2023
@ericsyh ericsyh requested a review from a team November 20, 2023 03:07
@ericsyh ericsyh added this to the sn-platform-1.11.3 milestone Nov 27, 2023
@ericsyh
Copy link
Member Author

ericsyh commented Nov 28, 2023

@tuteng @maxsxu @ciiiii @urfreespace PTAL

@ericsyh ericsyh merged commit effb79b into master Dec 4, 2023
4 checks passed
@ericsyh ericsyh deleted the datadog-annotation branch December 4, 2023 07:59
ericsyh added a commit that referenced this pull request Dec 4, 2023
* add datadog annotations for autorecovery

Signed-off-by: ericsyh <[email protected]>

* apply to sn-platform chart

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit effb79b)
ericsyh added a commit that referenced this pull request Dec 4, 2023
* add datadog annotations for autorecovery

Signed-off-by: ericsyh <[email protected]>

* apply to sn-platform chart

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit effb79b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants