Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets for jwt init job #1123

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Nov 6, 2023

Fixes #1122

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from sijie and a team as code owners November 6, 2023 09:42
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 6, 2023
@ericsyh ericsyh merged commit 5792b4f into master Nov 7, 2023
4 checks passed
@ericsyh ericsyh deleted the yscai/jwt-job-image-pull-secret branch November 7, 2023 01:04
ericsyh pushed a commit that referenced this pull request Nov 7, 2023
Add imagePullSecrets in jwt init job

(cherry picked from commit 5792b4f)
ericsyh pushed a commit that referenced this pull request Nov 7, 2023
Add imagePullSecrets in jwt init job

(cherry picked from commit 5792b4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't specify imagePullSecret for jwt init job
2 participants