Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sn-platform] Avoid downloading in jwt secret int job #1121

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Nov 1, 2023

Fixes #1119

Motivation

Modifications

  • copy kubectl binary from initContainer
  • Make isito-proxy quit after job completed

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from sijie and a team as code owners November 1, 2023 06:10
@ciiiii ciiiii requested review from tuteng and ericsyh November 1, 2023 06:10
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 1, 2023
@ericsyh ericsyh merged commit 775a6e4 into master Nov 2, 2023
3 checks passed
@ericsyh ericsyh deleted the yscai/remove-download branch November 2, 2023 02:21
ericsyh pushed a commit that referenced this pull request Nov 2, 2023
* Remove kubectl download

* Make isito-proxy quit after job completed

* Apply to slim

* Fix curl when istio disabled

(cherry picked from commit 775a6e4)
ericsyh pushed a commit that referenced this pull request Nov 2, 2023
* Remove kubectl download

* Make isito-proxy quit after job completed

* Apply to slim

* Fix curl when istio disabled

(cherry picked from commit 775a6e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sn-platform] Avoid downloading in Job jwt-secret-init
3 participants