Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Istio migration mode #1116

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Support Istio migration mode #1116

merged 2 commits into from
Oct 26, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Oct 22, 2023

Fixes #1110

Motivation

Support migrate workloads from non-Istio to Istio

Modifications

  • Make mtls mode permissive for Istio migration

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from sijie and a team as code owners October 22, 2023 03:26
@github-actions github-actions bot added the doc-required This pr needs a document label Oct 22, 2023
@ciiiii
Copy link
Member Author

ciiiii commented Oct 22, 2023 •
edited
Loading

  1. deploy sn-platform with Istio disabled
  2. upgrade with the Istio migration mode 
    ...
--set istio.enabled=true \
--set istio.migration=true \
--set initialize=false \
--set ingress.broker.external_domain=example.com \
--set ingress.broker.enabled=true
  3. upgrade with Istio enabled 
    ...
--set istio.enabled=true \
--set istio.migration=false \
--set initialize=false \
--set ingress.broker.external_domain=example.com \
--set ingress.broker.enabled=true

@ericsyh
Copy link
Member

ericsyh commented Oct 24, 2023

pls also add this to the slim chart.

@ericsyh ericsyh merged commit 1b38177 into master Oct 26, 2023
3 checks passed
@ericsyh ericsyh deleted the yscai/istio-migration branch October 26, 2023 00:42
ericsyh pushed a commit that referenced this pull request Oct 31, 2023
@ciiiii @ericsyh
Support Istio migration mode (#1116)
670329f 
* Make mtls mode permissive for Istio migration

* Apply to slim

(cherry picked from commit 1b38177)
ericsyh pushed a commit that referenced this pull request Oct 31, 2023
@ciiiii @ericsyh
Support Istio migration mode (#1116)
6203426 
* Make mtls mode permissive for Istio migration

* Apply to slim

(cherry picked from commit 1b38177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsyh ericsyh ericsyh approved these changes

@sijie sijie Awaiting requested review from sijie

Assignees

@ciiiii ciiiii

Labels
doc-required This pr needs a document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sn-platform] Support migrate from non-Istio to Istio
2 participants
@ciiiii @ericsyh