[charts/sn-platform] Add prometheus pod name to sts env #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specify certs.internalal_issuer.typ = secret, the output of issuer
spec:
ca:ca:
secretName: root-ca-secret
fix syntax
ericsyh
reviewed
Aug 18, 2023
ericsyh
reviewed
Aug 18, 2023
yuweisung
commented
Sep 20, 2023
zerbitx
approved these changes
Oct 17, 2023
4 tasks
ericsyh
approved these changes
Oct 26, 2023
ericsyh
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix repeat ca tag
When specify certs.internalal_issuer.typ = secret, the output of issuer
spec:
ca:ca:
secretName: root-ca-secret
* Update tls-cert-internal-issuer.yaml
fix syntax
* add external labels
* fix the var naming
* pod_name is required for prometheus ha detector
* missed curly quotes
* remove test
---------
Co-authored-by: Eric Shen <[email protected]>
(cherry picked from commit bfe9657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prometheus HA uses $POD_NAME to detect which pod is active. Add env POD_NAME to prometheus statefulset template.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)