fix: detector extraArgs missed default auth configs (#1167)

* fix: detector extraArgs missed default auth configs Signed-off-by: ericsyh <[email protected]> * fix the comments Signed-off-by: ericsyh <[email protected]> * fix lint Signed-off-by: ericsyh <[email protected]> * fix lint Signed-off-by: ericsyh <[email protected]> --------- Signed-off-by: ericsyh <[email protected]> (cherry picked from commit d1d15fe)
streamnative · Jun 10, 2024 · 74560f6 · 74560f6
1 parent 8c4d5e3
commit 74560f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml b/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml
@@ -126,12 +126,16 @@ spec:
           -{{ $key }}
           {{- end }}
           {{- end }}
+          {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} 
+          -auth-plugin token 
+          -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" 
+          {{- end }}
           -service-url {{ template "pulsar.detector.serviceUrl" . }}
           -webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
         {{- else }}
         args:
         - >
-          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if .Values.auth.authentication.enabled }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
+          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
         {{- end }}
         {{- if .Values.pulsar_detector.resources }}
         resources: {{- toYaml .Values.pulsar_detector.resources | nindent 10 }}

diff --git a/charts/sn-platform/templates/detector/pulsar-detector-deployment.yaml b/charts/sn-platform/templates/detector/pulsar-detector-deployment.yaml
@@ -126,12 +126,16 @@ spec:
           -{{ $key }}
           {{- end }}
           {{- end }}
+          {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} 
+          -auth-plugin token 
+          -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" 
+          {{- end }}
           -service-url {{ template "pulsar.detector.serviceUrl" . }}
           -webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
         {{- else }}
         args:
         - >
-          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if .Values.auth.authentication.enabled }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
+          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
         {{- end }}
         {{- if .Values.pulsar_detector.resources }}
         resources: {{- toYaml .Values.pulsar_detector.resources | nindent 10 }}