Feature/block filtering impl #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sduchesneau
force-pushed
the
feature/block_filtering_impl
branch
from
9051e3b to
cf246c3
Compare
sduchesneau
requested changes
Mar 14, 2024
manifest/package.go
Outdated
| @@ -80,6 +80,23 @@ func (r *manifestConverter) validateManifest(manif *Manifest) error { | |||
| if s.Use != "" { | |||
| return fmt.Errorf("stream %q: 'use' is not allowed for kind 'store'", s.Name) | |||
| } | |||
| case ModuleKindBlockIndex: | |||
| if s.Inputs != nil { | |||
| return fmt.Errorf("stream %q: block index module cannot have inputs", s.Name) | |||
There was a problem hiding this comment.
Au contraire, it must have at least one input, but not of "param" type
manifest/package_test.go
Outdated
| manifest: &Manifest{ | ||
| SpecVersion: "v0.1.0", | ||
| Modules: []*Module{ | ||
| {Name: "basic_index", Kind: "blockIndex", Output: StreamOutput{"proto:sf.substreams.index.v1.Keys"}}, |
There was a problem hiding this comment.
Add an input (type source:block or something...) to all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup Block Filter attribute and Block Index Kind