add a request limit for tier2 service, if reached service sets itself as not ready. #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduchesneau
reviewed
Mar 11, 2024
service/tier2.go
Outdated
| overloaded = false | ||
| } | ||
| if overloaded { | ||
| defer s.connectionCountMutex.Unlock() |
sduchesneau
reviewed
Mar 11, 2024
service/tier2.go
Outdated
| @@ -121,6 +126,26 @@ func (s *Tier2Service) ProcessRange(request *pbssinternal.ProcessRangeRequest, s | |||
| var err error | |||
| ctx := streamSrv.Context() | |||
|
|
|||
| overloaded := true | |||
There was a problem hiding this comment.
reverse this logic (default: false)
sduchesneau
reviewed
Mar 11, 2024
service/tier2.go
Outdated
| defer func() { | ||
| s.connectionCountMutex.Lock() | ||
| s.currentConcurrentRequests-- | ||
| s.setReadyFunc(s.runtimeConfig.MaxConcurrentRequests == 0 || s.currentConcurrentRequests < s.runtimeConfig.MaxConcurrentRequests) |
There was a problem hiding this comment.
transform this into a function (use same as line 131)
|
Add to CHANGELOG |
colindickson
force-pushed
the
feature/tier2-request-limit
branch
from
cf73f25 to
c21aca1
Compare
|
TODO: add the prometheus metrics for active requests on a tier2 in our graphs |
|
TODO: ensure that the tier1 never fails on tier2 unavailable (I think there's a retry counter limit...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed