Feature/deployable

[sduchesneau]

Added

• Sink configs can now use protobuf annotations (aka Field Options) to determine how the field will be interpreted in
  substreams.yaml:

  • load_from_file will put the content of the file directly in the field (string and bytes contents are supported).
  • zip_from_folder will create a zip archive and put its content in the field (field type must be bytes).

  Example:

  import "sf/substreams/v1/options.proto";
  optional bytes schema = 1 [ (sf.substreams.v1.options).load_from_file = true ];`
  optional bytes extra_config_files = 2 [ (sf.substreams.v1.options).zip_from_folder = true ];`
  

• substreams info command now properly displays the sink configs, optionally writing the bytes fields to disk with --dump-sinkconfig-bytes-to-disk flag

Removed

• The @path/to/textfile and @@path/to/binaryfile notations under sink_configs in substreams.yaml are now DEPRECATED (they will still work but with a warning).

[maoueh]

Let's showcase the message ... part as it's not clear like that where those are used. Would probably use a "complete" message.

[maoueh]

The literal is repeated, let's extract it (can we even extract from the Message directly).

[maoueh]

Really hard to read and reason about

[maoueh]

At the very minimum, a quick comment is required.

[maoueh]

Suggested change

	// this flag informs the `substreams pack` command that it should treat the corresponding manifest value as a path to a file, putting its content as bytes in this field.
	// This option informs the `substreams pack` command that it should treat the corresponding manifest value as a path to a file, putting its content as bytes in this field.

[maoueh]

Suggested change

	// this flag informs the `substreams pack` command that it should treat the corresponding manifest value as a path to a folder, zipping its content and putting the zip content as bytes in this field.
	// This option informs the `substreams pack` command that it should treat the corresponding manifest value as a path to a folder, zipping its content and putting the zip content as bytes in this field.

[maoueh]

I think there is a central repo that list used/unsued value here, did you see something about that?

[maoueh]

I dislike the fact that converting to string also dumps to file. In fact more reading lead me to think that this function is weirdly named.

It also deals with representational aspect, the output being a new-line separated string. The function should return a []string and let the caller decide what to do.

I also think the path where to write things should be pass in by the caller. Inferring tmp seems unecessary, the caller should deal with this decision.