add missing page_info / cursors for Association Proxy logic

[tylernisonoff]

Description

association_proxy_resolver_for has a few code blocks that were not updated for the relay changes. Association proxy mapping would fail due do constructors missing either page_info or cursor args.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

• N/a

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

I haven't added tests as it looks like this code is originally untested.

Summary by Sourcery

Bug Fixes:

• Fix association proxy mapping failures due to missing page_info or cursor arguments in constructors.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request addresses a bug in the association_proxy_resolver_for function where it was not updated to handle relay pagination. This resulted in missing page_info and cursor arguments in the constructors, causing failures in association proxy mapping. The changes ensure that the connection_type is properly initialized with the necessary page_info and cursor data when resolving relationships.

Sequence diagram for association proxy resolver with relay pagination

sequenceDiagram
    participant Client
    participant Resolver
    participant AssociationProxy
    participant Connection

    Client->>Resolver: Request data
    Resolver->>AssociationProxy: resolve(info)
    alt in_between_objects is None
        AssociationProxy-->>Connection: Create with empty edges + PageInfo
    else has objects
        AssociationProxy->>AssociationProxy: Process objects
        AssociationProxy-->>Connection: Create with edges + PageInfo + cursors
    end
    Connection-->>Client: Return paginated data

Loading

Class diagram for connection types with relay pagination

classDiagram
    class PageInfo {
        +boolean has_next_page
        +boolean has_previous_page
        +string start_cursor
        +string end_cursor
    }

    class ConnectionType {
        +List~Edge~ edges
        +PageInfo page_info
    }

    class Edge {
        +Object node
        +string cursor
    }

    ConnectionType *-- PageInfo
    ConnectionType *-- Edge

Loading

File-Level Changes

Change	Details	Files
Add page_info and cursor arguments to the connection_type constructor when resolving relationships.	When no in-between objects are found, initialize connection_type with an empty list of edges and a page_info object with default values. When in-between objects are found, initialize connection_type with a list of edges and a page_info object with start_cursor and end_cursor values.	src/strawberry_sqlalchemy_mapper/mapper.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

Fixes relay pagination logic fo association proxy logic.

[sourcery-ai]

Hey @tylernisonoff - I've reviewed your changes - here's some feedback:

Overall Comments:

• The hardcoded has_next_page and has_previous_page values should be calculated based on the actual data and pagination parameters rather than always being set to False
• Consider adding tests for the pagination behavior to prevent future regressions, even though the original code was untested

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}