Enhancement: Improve debug logging condition #58
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if
WP_DEBUG
is defined andtrue
instead of checkingWP_DEBUG_LOG
.All Submissions:
Changes proposed in this Pull Request:
Check if
WP_DEBUG
is defined andtrue
instead of checkingWP_DEBUG_LOG
as this may sometimes return true if a file location was set as this constant's value instead of a boolean which may lead to error logging in the PHP Log file even if WP_DEBUGis set to
false`How to test the changes in this Pull Request:
php.ini
configuration.WP_DEBUG
tofalse
and set a file location forWP_DEBUG_LOG
, e.g.define( 'WP_DEBUG_LOG', '/var/www/my-wp-debug-log.log' );
.Other information:
Changelog entry