Skip to content

Commit

Permalink
Updating headings hierarchy to match new PMPro checkout page for a11y
Browse files Browse the repository at this point in the history
PMPro v2.11 updated the checkout page headings hierarchy from h3 to h2. This PR updates this Add On to follow the same pattern for accessibility.
  • Loading branch information
kimwhite committed Jul 12, 2023
1 parent e672559 commit ba2f5e7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions includes/functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ function pmpromc_additional_lists_on_checkout() {
?>
<div id="pmpro_mailing_lists" class="pmpro_checkout" <?php echo( $display_modifier ); ?>>
<hr />
<h3>
<span class="pmpro_checkout-h3-name">
<h2>
<span class="pmpro_checkout-h2-name">
<?php
if ( count( $additional_lists_array ) > 1 ) {
esc_html_e( 'Join one or more of our mailing lists.', 'pmpro-mailchimp' );
Expand All @@ -191,7 +191,7 @@ function pmpromc_additional_lists_on_checkout() {
}
?>
</span>
</h3>
</h2>
<div class="pmpro_checkout-fields">
<?php
global $current_user;
Expand Down
2 changes: 1 addition & 1 deletion includes/profile.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function pmpromc_add_custom_user_profile_fields( $user ) {

if ( ! isset( $pmpro_pages['member_profile_edit'] ) || ! is_page( $pmpro_pages['member_profile_edit'] ) ) {
?>
<h3><?php esc_html_e( 'Opt-in Mailchimp Audiences', 'pmpro-mailchimp' ); ?></h3>
<h2><?php esc_html_e( 'Opt-in Mailchimp Audiences', 'pmpro-mailchimp' ); ?></h2>

<table class="form-table">
<tr>
Expand Down
6 changes: 3 additions & 3 deletions includes/settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,18 @@ function pmpromc_options_page()
<?php } ?>

<form action="options.php" method="post">
<h3><?php _e('Subscribe users to one or more Mailchimp audiences when they sign up for your site.', 'pmpro-mailchimp');?></h3>
<h2><?php _e('Subscribe users to one or more Mailchimp audiences when they sign up for your site.', 'pmpro-mailchimp');?></h2>
<p><?php printf(__('If you have <a href="%s" target="_blank">Paid Memberships Pro</a> installed, you can subscribe members to one or more Mailchimp audiences based on their membership level or specify "Opt-in Audiences" that members can select at membership checkout. <a href="%s" target="_blank">Get a Free Mailchimp account</a>.', 'pmpro-mailchimp'), 'https://www.paidmembershipspro.com', 'http://eepurl.com/k4aAH');?></p>
<?php if (function_exists('pmpro_getAllLevels')) { ?>
<hr/>
<h3><?php _e("Synchronize a Member's Level Name and ID", 'pmpro-mailchimp');?></h3>
<h2><?php _e("Synchronize a Member's Level Name and ID", 'pmpro-mailchimp');?></h2>
<p><?php _e("Since v2.0, this plugin creates and synchronizes the <code>PMPLEVEL</code> and <code>PMPLEVELID</code> merge field in Mailchimp. <strong>This will only affect new or updated members.</strong> You must import this data into MailChimp for existing members.", 'pmpro-mailchimp');?> <a href="http://www.paidmembershipspro.com/import-level-name-id-existing-members-using-new-merge-fields-pmpro-mailchimp-v2-0/" target="_blank"><?php _e('Read the documentation on importing existing members into MailChimp', 'pmpro-mailchimp');?></a>.</p>
<p><a class="button" onclick="jQuery('#pmpromc_export_instructions').show();"><?php _e('Click here to export your members list for a MailChimp Import', 'pmpro-mailchimp');?></a></p>
<hr/>

<div id="pmpromc_export_instructions" class="postbox" style="display: none;">
<div class="inside">
<h3><?php _e('Export a CSV for your Mailchimp Import', 'pmpro-mailchimp');?></h3>
<h2><?php _e('Export a CSV for your Mailchimp Import', 'pmpro-mailchimp');?></h2>
<p><?php _e('Membership Level', 'pmpro-mailchimp');?>:
<select id="pmpromc_export_level" name="l">
<?php
Expand Down

0 comments on commit ba2f5e7

Please sign in to comment.