Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make annotate return instance of actual MockSet class #179

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

nfantone
Copy link
Contributor

@nfantone nfantone commented Sep 4, 2024

While other MockSet methods, such as exclude or filter, return an instance of the actual MockSet class being used, annotate doesn't.

This fixes that.

@stefan6419846
Copy link
Collaborator

Could you please add a corresponding test as well which verifies that the returned types are indeed correct?

@nfantone
Copy link
Contributor Author

nfantone commented Sep 4, 2024

Hi @stefan6419846 👋🏼

There are several methods that have their returned value determined by self._mockset_class() and none of them are being tested for that, at the moment.

I've added one for annotate, which is what this PR introduces.

If you think the others methods should still be tested, feel free to extend this PR.

@nfantone nfantone force-pushed the annotate-mockset-class branch from 5ad6b24 to a7a7350 Compare September 4, 2024 15:04
@nfantone nfantone force-pushed the annotate-mockset-class branch from a7a7350 to 67988f4 Compare September 4, 2024 15:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (8f1448c) to head (67988f4).
Report is 15 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files           7        7           
  Lines         952      952           
=======================================
  Hits          949      949           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfantone
Copy link
Contributor Author

nfantone commented Sep 5, 2024

@stefan6419846 Anything else you'd like me to address over here?

@stefan6419846 stefan6419846 merged commit 8d1047e into stphivos:master Sep 6, 2024
16 checks passed
@nfantone nfantone deleted the annotate-mockset-class branch September 6, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants