Add return value to MockSet delete #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvieirajr
reviewed
Nov 12, 2021
|
|
||
| if self.clone is not None: | ||
| self.clone._delete_recursive(*items_to_remove, **attrs) | ||
|
|
||
| return sum_deleted, items_deleted |
There was a problem hiding this comment.
you dont need to store a sum_deleted variable.
You can just use return sum(items_delete.values()), items_deleted
|
What is the current status of this PR? |
|
Ping? |
|
Closed in favor of #184. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior for the QuerySets delete in Django is to return a tuple with the number of entries deleted, and a dictionary with how many entries were deleted for each type.
This PR aims to simulate that behavior.