Improve Dispute module functions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
edisonz0718
reviewed
Feb 9, 2024
| client.dispute.whitelistDisputeTags({ | ||
| tag: "testTag", | ||
| allowed: true, | ||
| describe("[Write Functions] Should be able to", async function () { |
There was a problem hiding this comment.
All write functions are skipped right now. Are they working?
There was a problem hiding this comment.
Doesn't work unless we have a working ArbitrationPolicy fixture
There was a problem hiding this comment.
Also, setDisputeJudgement won't work unless we set up the whitelisted Arbitration relayer contract (or whatever it's called)
| linkToDisputeEvidence: string; | ||
| targetTag: string; | ||
| export type CancelDisputeRequest = { | ||
| disputeId: number | string | bigint; |
There was a problem hiding this comment.
I think we just use either number or string here. Otherwise users have to figure out which types to use.
There was a problem hiding this comment.
I think bigint is ok here. If a user uses ethers/wagmi to read directly from the contract, that output is bigint type.
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
edisonz0718
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.