Fix: StoryClient Initialization in StoryProvider #372
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
StoryClient
was being re-initialized on every render inside theStoryProvider
component. This led to an infinite re-render loop and impacted the application’s performance.Problem & Solution:
The
StoryClient
was being re-created on every render, causing an infinite re-render loop. By implementing lazy initialization, the client is now created only once when needed, preventing unnecessary renders and improving performance.Key Changes:
StoryClient
initialization is moved to auseEffect
hook, ensuring it is created only once when the component is first mounted.Test Plan
Steps to Verify:
Initial Render:
StoryClient
is created only once during the component's first render.Loading State:
StoryClient
is being initialized.Edge Cases:
StoryClient
to ensure no unexpected errors or performance issues occur.Related Issue
N/A
Notes
This update optimizes the performance of the
StoryProvider
component and ensures theStoryClient
is only initialized when needed, reducing unnecessary renders. Minor refactoring has also been applied to maintain compatibility.