fix: typos in documentation #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make isRegistered public * make isRegistered public
* Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2
evg1nn-eth
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
evg1nn-eth
had a problem deploying
to
external
GitHub Actions
Failure
allenchuang
force-pushed
the
dev
branch
2 times, most recently
from
28f0ff0 to
b18d633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses several spelling and grammatical issues across the codebase. These changes help improve code clarity and reduce the likelihood of confusion for contributors and users. Specifically, the following corrections were made:
"Once publish core-sdk" — the phrase needs correction for grammatical correctness. It should be "Once you publish the core-sdk".
"published in store" — the phrase needs clarification. It would be better to write "published to the store".
"The preceding code created the account object" — the verb tense should be present, not past, since it's describing an action. It should be "The preceding code creates the account object".
"created the account object for creating" — there is repetition of the word "creating." It should be rewritten as "creates the
accountobject for the SDK client"."store." — the word "store" in this context may be unclear. It would be better to change it to "the store".
"need you are trying to solve" — the phrase should be "need that you are trying to solve."
These fixes were primarily applied in variable names, comments, and documentation.
No new dependencies were introduced as part of these changes.
How Has This Been Tested?
The changes do not affect functionality but improve code readability. As a result, no new tests were needed.
All existing unit and integration tests were run to ensure the correctness of the system.
Key Areas to Review
Which Components or Systems Does This Change Impact?
Checklist